Fix kaniko permissions with generate-pipeline command #2622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlon-gamez
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
tejal29
approved these changes
Aug 8, 2019
Codecov Report
|
tejal29
suggested changes
Aug 9, 2019
tejal29
reviewed
Aug 9, 2019
tejal29
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes functions used by generate-pipeline command to only add kaniko information to profile artifacts when necessary. Also adds GOOGLE_APPLICATION_CREDENTIALS env variable to tekton tasks when an artifact is built with kaniko.
Updated integration tests to match the new pipeline output.