Log a warning and rebuild if needed when caching fails #2685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
priyawadhwa
added
the
priority/p0
Codecov Report
|
balopat
reviewed
Aug 20, 2019
balopat
approved these changes
Aug 20, 2019
since we aren't erroring out, red is a bit aggressive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should never error out if caching fails. Instead, log a warning and rebuild the artifact if it still needs to be rebuilt.
Should fix #2677
cc @balopat @briandealwis @prary