Skip to content

Add missing T.Helper() in testutil.Check* as required #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

briandealwis
Copy link
Member

Turns

--- FAIL: TestWalk (0.02s)
    --- FAIL: TestWalk/should_return_correct_k8_configs_and_build_files (0.00s)
        util.go:69: int differ (-got, +want):   int(
            - 	4,
            + 	5,
              )
        util.go:69: string differ (-got, +want):   strings.Join({
              	"/var/folders/mx/_6wvyq4n3psb4nj95d8ycpv80000gn/T/skaffold7141983",
              	"63/",
            - 	"maven/pom.xml",
            + 	"gradle-kotlin/build.gradle.kts",
              }, "")

into

--- FAIL: TestWalk (0.02s)
    --- FAIL: TestWalk/should_return_correct_k8_configs_and_build_files (0.00s)
        init_test.go:281: int differ (-got, +want):   int(
            - 	4,
            + 	5,
              )
        init_test.go:283: string differ (-got, +want):   strings.Join({
              	"/var/folders/mx/_6wvyq4n3psb4nj95d8ycpv80000gn/T/skaffold9003403",
              	"91/",
            - 	"maven/pom.xml",
            + 	"gradle-kotlin/build.gradle.kts",
              }, "")

@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #2913 into master will not change coverage.
The diff coverage is n/a.

@tejal29 tejal29 merged commit 5c1f4a4 into GoogleContainerTools:master Sep 19, 2019
@briandealwis briandealwis deleted the thelper branch November 11, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants