Skip to content

Bump golangci-lint to v0.19.0 #2927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

corneliusweig
Copy link
Contributor

@corneliusweig corneliusweig commented Sep 23, 2019

Description

Bump golangci-lint to v0.19.0
This required to align receiver names as reported by stylecheck. Here, I opted for the one-letter short forms instead of the longer receiver names. Maybe for the configs this is not the right way?

User facing changes

n/a

Before

n/a

After

n/a

Next PRs.

n/a

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Align receiver names as reported by stylecheck

Signed-off-by: Cornelius Weig <[email protected]>
@codecov
Copy link

codecov bot commented Sep 23, 2019

Codecov Report

Merging #2927 into master will not change coverage.
The diff coverage is 84.05%.

Impacted Files Coverage Δ
pkg/skaffold/sync/sync.go 75% <0%> (ø) ⬆️
pkg/skaffold/schema/v1beta10/upgrade.go 100% <100%> (ø) ⬆️
pkg/skaffold/schema/v1beta11/upgrade.go 100% <100%> (ø) ⬆️
pkg/skaffold/schema/v1alpha3/upgrade.go 100% <100%> (ø) ⬆️
pkg/skaffold/schema/v1beta7/upgrade.go 100% <100%> (ø) ⬆️
pkg/skaffold/schema/v1alpha5/upgrade.go 100% <100%> (ø) ⬆️
pkg/skaffold/schema/v1beta1/upgrade.go 100% <100%> (ø) ⬆️
pkg/skaffold/schema/v1alpha4/upgrade.go 100% <100%> (ø) ⬆️
pkg/skaffold/schema/v1beta6/upgrade.go 100% <100%> (ø) ⬆️
pkg/skaffold/schema/v1beta12/upgrade.go 100% <100%> (ø) ⬆️
... and 9 more

@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Sep 24, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Sep 24, 2019
Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balopat balopat merged commit 207ccf9 into GoogleContainerTools:master Sep 25, 2019
@corneliusweig corneliusweig deleted the w/update-linter branch September 25, 2019 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants