Skip to content

Specifying artifact location i.e locally or remote #2958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 2, 2019

Conversation

prary
Copy link
Contributor

@prary prary commented Sep 28, 2019

Relates to #2950

Description
Location of cached image i.e local or remote
User facing changes

yes

Before

DEBU[0000] Found dependencies for dockerfile: [{app.py / true}]
 - .........../test/artifact/py: Found 

After

DEBU[0000] Found dependencies for dockerfile: [{app.py / true}]
 - .........../test/artifact/py: Found remotely

Next PRs.
N/A

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

@codecov
Copy link

codecov bot commented Sep 30, 2019

Codecov Report

Merging #2958 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/build/cache/retrieve.go 64.63% <100%> (+1.34%) ⬆️

Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @prary thanks for submitting this! I think we can simplify this considerably be removing the Location from the cacheDetails interface and using imagesFoundLocally as described in my comment.

@priyawadhwa priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label Oct 1, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Oct 1, 2019
@pull-request-size pull-request-size bot added size/XS and removed size/M labels Oct 2, 2019
@tejal29 tejal29 merged commit a0efe33 into GoogleContainerTools:master Oct 2, 2019
@prary prary deleted the cached_artifact_location branch October 3, 2019 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants