Skip to content

[custom] Test error case #3004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2019
Merged

[custom] Test error case #3004

merged 1 commit into from
Oct 7, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Oct 7, 2019

Signed-off-by: David Gageot [email protected]

@dgageot
[custom] Test error case
203750a 
Signed-off-by: David Gageot <[email protected]>
@codecov
Copy link

codecov bot commented Oct 7, 2019 •
edited
Loading

Codecov Report

Merging #3004 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/docker/dependencies.go 73.91% <0%> (+2.17%) ⬆️
pkg/skaffold/build/custom/dependencies.go 83.33% <0%> (+8.33%) ⬆️

@priyawadhwa priyawadhwa merged commit ea88994 into GoogleContainerTools:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyawadhwa priyawadhwa priyawadhwa approved these changes

@balopat balopat Awaiting requested review from balopat

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @priyawadhwa @googlebot