Skip to content

Update docker and go-containerregistry #3053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -25,31 +25,28 @@ require (
github.com/Azure/go-autorest/autorest/to v0.3.0 // indirect
github.com/Azure/go-autorest/autorest/validation v0.2.0 // indirect
github.com/MakeNowJust/heredoc v0.0.0-20171113091838-e9091a26100e // indirect
github.com/Microsoft/go-winio v0.4.14 // indirect
github.com/Netflix/go-expect v0.0.0-20180928190340-9d1f4485533b // indirect
github.com/Nvveen/Gotty v0.0.0-20120604004816-cd527374f1e5 // indirect
github.com/aws/aws-sdk-go v1.23.15 // indirect
github.com/blang/semver v3.5.1+incompatible
github.com/bmatcuk/doublestar v1.1.5
github.com/containerd/continuity v0.0.0-20181027224239-bea7585dbfac // indirect
github.com/docker/cli v0.0.0-20181026145426-51668a30f262
github.com/docker/cli v0.0.0-20191011045415-5d85cdacd257
github.com/docker/distribution v2.7.1+incompatible
github.com/docker/docker v0.7.3-0.20190327010347-be7ac8be2ae0
github.com/docker/docker-credential-helpers v0.6.3 // indirect
github.com/docker/docker v1.4.2-0.20180531152204-71cd53e4a197
github.com/docker/go-connections v0.4.0
github.com/docker/go-metrics v0.0.1 // indirect
github.com/docker/go-units v0.3.3 // indirect
github.com/docker/libtrust v0.0.0-20160708172513-aabc10ec26b7 // indirect
github.com/docker/spdystream v0.0.0-20181023171402-6480d4af844c // indirect
github.com/emirpasic/gods v1.12.0 // indirect
github.com/ghodss/yaml v1.0.0
github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
github.com/golang/protobuf v1.3.2
github.com/google/go-cmp v0.3.1
github.com/google/go-containerregistry v0.0.0-20190905020052-226422ba1797
github.com/google/go-containerregistry v0.0.0-20191010200024-a3d713f9b7f8
github.com/google/go-github v17.0.0+incompatible
github.com/google/go-querystring v1.0.0 // indirect
github.com/google/uuid v1.1.1
github.com/googleapis/gnostic v0.2.2 // indirect
github.com/gorilla/context v1.1.1 // indirect
github.com/gorilla/mux v1.6.2 // indirect
github.com/grpc-ecosystem/grpc-gateway v1.8.6
Expand All @@ -64,7 +61,6 @@ require (
github.com/mattn/go-isatty v0.0.9 // indirect
github.com/mitchellh/go-homedir v1.1.0
github.com/moby/buildkit v0.3.3
github.com/morikuni/aec v0.0.0-20170113033406-39771216ff4c // indirect
github.com/opencontainers/go-digest v1.0.0-rc1
github.com/opencontainers/image-spec v1.0.1
github.com/opencontainers/runc v0.1.1 // indirect
Expand All @@ -75,7 +71,7 @@ require (
github.com/shurcooL/sanitized_anchor_name v1.0.0 // indirect
github.com/sirupsen/logrus v1.4.2
github.com/spf13/cobra v0.0.5
github.com/spf13/pflag v1.0.3
github.com/spf13/pflag v1.0.5
github.com/tektoncd/pipeline v0.5.1-0.20190731183258-9d7e37e85bf8
go.opencensus.io v0.22.1 // indirect
go.uber.org/atomic v1.4.0 // indirect
Expand All @@ -91,7 +87,6 @@ require (
google.golang.org/genproto v0.0.0-20190819201941-24fa4b261c55
google.golang.org/grpc v1.22.2
gopkg.in/AlecAivazis/survey.v1 v1.8.7
gopkg.in/inf.v0 v0.9.1 // indirect
gopkg.in/russross/blackfriday.v2 v2.0.1
gopkg.in/src-d/go-billy.v4 v4.3.0 // indirect
gopkg.in/src-d/go-git.v4 v4.11.0
Expand Down
37 changes: 31 additions & 6 deletions go.sum

Large diffs are not rendered by default.

19 changes: 17 additions & 2 deletions pkg/skaffold/docker/auth.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,12 @@ func (credsHelper) GetAuthConfig(registry string) (types.AuthConfig, error) {

gcp.AutoConfigureGCRCredentialHelper(cf, registry)

return cf.GetAuthConfig(registry)
auth, err := cf.GetAuthConfig(registry)
if err != nil {
return types.AuthConfig{}, err
}

return types.AuthConfig(auth), nil
}

func (credsHelper) GetAllAuthConfigs() (map[string]types.AuthConfig, error) {
Expand All @@ -77,7 +82,17 @@ func (credsHelper) GetAllAuthConfigs() (map[string]types.AuthConfig, error) {
return nil, errors.Wrap(err, "docker config")
}

return cf.GetAllCredentials()
credentials, err := cf.GetAllCredentials()
if err != nil {
return nil, err
}

authConfigs := make(map[string]types.AuthConfig, len(credentials))
for k, auth := range credentials {
authConfigs[k] = types.AuthConfig(auth)
}

return authConfigs, nil
}

func (l *localDaemon) encodedRegistryAuth(ctx context.Context, a AuthConfigHelper, image string) (string, error) {
Expand Down
26 changes: 26 additions & 0 deletions vendor/github.com/Nvveen/Gotty/LICENSE

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions vendor/github.com/Nvveen/Gotty/README

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions vendor/github.com/Nvveen/Gotty/TODO

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading