Warn when default or provided port not available for API Server #3065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3023
Description
While writing docs for Events API i discovered, if the default
--rpc-http-port
or--rpc-port
are not available, we don't have display any information to users on which ports these grpc server get started.User facing changes
yes
Before
skaffold dev
on any project in examples.skaffold dev
again.With default logging level is warn, there is no information regarding ports not being available. User will have to hit cntrl C and then re-run skaffold with
-v=debug
flag to see ports.After
skaffold dev
on any project in examples.skaffold dev
again.Next PRs.
n/a
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
examples
dir, please copy them tointegration/examples
integration/examples
dir, should be tested in integration testReviewer Notes