Skip to content

Warn when default or provided port not available for API Server #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2019

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Oct 16, 2019

Relates to #3023

Description

While writing docs for Events API i discovered, if the default --rpc-http-port or --rpc-port are not available, we don't have display any information to users on which ports these grpc server get started.

User facing changes

yes
Before

  1. run skaffold dev on any project in examples.
  2. In a new terminal, run skaffold dev again.
    With default logging level is warn, there is no information regarding ports not being available. User will have to hit cntrl C and then re-run skaffold with -v=debug flag to see ports.
tejaldesai@@getting-started (info_warn)$ skaffold dev
Listing files to watch...
 - gcr.io/k8s-skaffold/skaffold-example
List generated in 23.087317ms
..

After

  1. run skaffold dev on any project in examples.
  2. In a new terminal, run skaffold dev again.
tejaldesai@@getting-started (info_warn)$ ../../out/skaffold dev
WARN[0000] port 50051 for gRPC server already in use: using 50053 instead 
WARN[0000] port 50052 for gRPC HTTP server already in use: using 50055 instead 
Listing files to watch...
 - gcr.io/k8s-skaffold/skaffold-example

Next PRs.

n/a

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [n/a ] Includes unit tests
  • [X ] Mentions any output changes.
  • [n/a ] Adds documentation as needed: user docs, YAML reference, CLI reference.
  • [ n/a] Adds integration tests if needed.

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #3065 into master will not change coverage.
The diff coverage is 0%.

Impacted Files Coverage Δ
pkg/skaffold/server/server.go 58.57% <0%> (ø) ⬆️

@tejal29 tejal29 changed the title Warn when default or provided port not available when starting grpc s… Warn when default or provided port not available for API Server Oct 16, 2019
@tejal29 tejal29 mentioned this pull request Oct 16, 2019
7 tasks
@tejal29 tejal29 merged commit 441c51c into GoogleContainerTools:master Oct 16, 2019
@tejal29 tejal29 deleted the info_warn branch April 15, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants