Skip to content

[Custom] Clearer message when image was not built #3085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Oct 18, 2019

When the custom script failed to build the image with the provided tag, it used to give an error like:

building [img]: Error parsing reference: "" is not a valid repository/tag: invalid reference format 

It's now:

building [img]: build artifact: The custom script didn't produce an image with tag [img:tag]

Will help debugs issue like #3077

Signed-off-by: David Gageot [email protected]

@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #3085 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted Files Coverage Δ
pkg/skaffold/build/local/custom.go 13.33% <0%> (-6.67%) ⬇️

@dgageot dgageot force-pushed the custom-clear-error branch from 1413308 to 7920748 Compare October 18, 2019 09:50
@tejal29 tejal29 merged commit 00a953b into GoogleContainerTools:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants