-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Implement render for kustomize #3110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement render for kustomize #3110
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
return NewDeploySuccessResult(namespaces) | ||
} | ||
|
||
func (k *KustomizeDeployer) renderManifests(ctx context.Context, out io.Writer, builds []build.Artifact, labellers []Labeller) (deploy.ManifestList, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why Render
doesn't have []Labeller
as parameter. I think that's something that should get added in the future so the behaviour is similar to Deploy
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should have it. looks like maybe I forgot to put it in there when I added the boilerplate a while back.
Codecov Report
|
aaa3ec5
to
f908b60
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
f908b60
to
d35d3ae
Compare
d35d3ae
to
a009263
Compare
@dgageot No sure whom to mention but is this PR going to make it? Should i keep it updated? |
Sorry @arminbuerkle, the team was quite busy launching version 1.0. I guess it's best to ping @nkubala |
a009263
to
5daa2e0
Compare
5daa2e0
to
387829f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @arminbuerkle, thanks for the contribution and really sorry it took me ages to get to you on this one!
I implemented this in #2911 a while ago, but closed it to split it up into smaller PRs and never got it back in. what you have here is very close to my original PR, but can you have a look at my implementation there and try and match what you have to that? specifically around the event handling and the labels being passed in to the renderer.
Signed-off-by: Armin Buerkle <[email protected]>
Signed-off-by: Armin Buerkle <[email protected]>
Signed-off-by: Armin Buerkle <[email protected]>
387829f
to
ce818aa
Compare
@nkubala PTAL. I fixed the event handling. The labeling requires changing the I'm happy to submit a follow up PR that fixes labeling and introduces a cmd flag to allow setting labels when using skaffold render. |
Signed-off-by: Armin Buerkle <[email protected]>
Is there any update on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arminbuerkle sorry for taking so long with this one. I tested this out and it seems to work well enough, so let's go ahead and get this in. we should definitely have a follow up PR to enable setting labels in Render
- would you like to send that?
I opened #3482 to track.
Relates to #1937 and #2957 for kustomize.
Description
Implements the
render
command for kustomize. Basically copied the waykubectl render
works to kustomize to try it out. It works for my current purpose so i added a unit test.If it looks good you can merge it, if someone else is already working on this feel free to close it.
User facing changes
Implements the
render
command for kustomize.Next PRs.
n/a
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes