Skip to content

Fix splash #3147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 1, 2019
Merged

Fix splash #3147

merged 7 commits into from
Nov 1, 2019

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Nov 1, 2019

Fixes buttons alignment, colors and footer padding.

@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Nov 1, 2019
@container-tools-bot
Copy link

Please visit http://35.236.87.39:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 1, 2019
@codecov
Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #3147 into master will not change coverage.
The diff coverage is n/a.

@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Nov 1, 2019
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 1, 2019
@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Nov 1, 2019
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 1, 2019
@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Nov 1, 2019
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 1, 2019
@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Nov 1, 2019
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 1, 2019
@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Nov 1, 2019
@balopat
Copy link
Contributor Author

balopat commented Nov 1, 2019

interestingly both the docs previewer and our integration test on kaniko failed with the same getting external ip issue:

--- FAIL: TestBuildKanikoInsecureRegistry (313.35s)
    build_test.go:389: error getting external ip: timed out waiting for the condition

I'll restart again and see if it persisted since last night or not...

@container-tools-bot
Copy link

Please visit http://35.235.117.222:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 1, 2019
@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Nov 1, 2019
@container-tools-bot
Copy link

Please visit http://35.236.87.39:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 1, 2019
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@nkubala nkubala merged commit e7aa4c1 into GoogleContainerTools:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants