Skip to content

[docs] update buildpacks tutorial to custom builder #3166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 5, 2019
Merged

[docs] update buildpacks tutorial to custom builder #3166

merged 8 commits into from
Nov 5, 2019

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Nov 4, 2019

Description
Update build packs tutorials, and rename it to Custom Builder

User facing changes

Next PRs.

  • Add a Tutorial for BuildPacks Native Builder.

Submitter Checklist

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

@tejal29 tejal29 added the docs-modifications runs the docs preview service on the given PR label Nov 4, 2019
@container-tools-bot
Copy link

Please visit http://35.236.5.148:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 4, 2019
@codecov
Copy link

codecov bot commented Nov 4, 2019 •
edited
Loading

Codecov Report

Merging #3166 into master will not change coverage.
The diff coverage is n/a.

@balopat balopat added the priority/p0 Highest priority. We are actively looking at delivering it. label Nov 4, 2019
@balopat balopat changed the title update buildpacks tutorial to custom builder [docs] update buildpacks tutorial to custom builder Nov 4, 2019
balopat
balopat suggested changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please udpate IMAGES -> IMAGE env var

@balopat
Copy link
Contributor

balopat commented Nov 4, 2019

This looks like a legit failure:

--- FAIL: TestBuild (9.17s)
    --- PASS: TestBuild/docker_build (7.10s)
    --- PASS: TestBuild/git_tagger (0.33s)
    --- PASS: TestBuild/sha256_tagger (0.21s)
    --- PASS: TestBuild/dateTime_tagger (0.20s)
    --- PASS: TestBuild/envTemplate_tagger (0.21s)
    --- FAIL: TestBuild/custom (1.12s)
        helper.go:169: skaffold build: exit status 1, Generating tags...
             - gcr.io/k8s-skaffold/skaffold-example -> gcr.io/k8s-skaffold/skaffold-example:v0.41.0-64-g8bb800b
            Found [kubernetes-admin@kind] context, using local docker daemon.
            Building [gcr.io/k8s-skaffold/skaffold-example]...
            ./build.sh: line 11: syntax error near unexpected token `fi'

nkubala
nkubala previously requested changes Nov 4, 2019
View reviewed changes
@tejal29 tejal29 dismissed nkubala’s stale review November 5, 2019 21:14

fixed commets

@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Nov 5, 2019
@container-tools-bot
Copy link

Please visit http://34.94.185.45:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 5, 2019
@tejal29 tejal29 merged commit 133ddec into GoogleContainerTools:master Nov 5, 2019
@tejal29 tejal29 deleted the update_buildpacks branch April 15, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat requested changes

@nkubala nkubala nkubala left review comments

@dgageot dgageot Awaiting requested review from dgageot

Assignees
No one assigned
Labels
cla: yes priority/p0 Highest priority. We are actively looking at delivering it. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tejal29 @container-tools-bot @balopat @nkubala @googlebot