Improve the k8s yaml used in buildpacks sample #3182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
force-pushed
the
improve-buildpacks-sample
branch
from
710200c to
44c39fc
Compare
dgageot
force-pushed
the
improve-buildpacks-sample
branch
3 times, most recently
from
6a12d1f to
6c715d2
Compare
Use a deployment/service instead of just a pod Signed-off-by: David Gageot <[email protected]>
dgageot
force-pushed
the
improve-buildpacks-sample
branch
from
6c715d2 to
e0eb085
Compare
balopat
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a deployment/service instead of just a pod
Signed-off-by: David Gageot [email protected]