-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add debug events to notify of debugging containers started and terminated #3312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
briandealwis
wants to merge
19
commits into
GoogleContainerTools:master
from
briandealwis:DebugEvents
Closed
Add debug events to notify of debugging containers started and terminated #3312
briandealwis
wants to merge
19
commits into
GoogleContainerTools:master
from
briandealwis:DebugEvents
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
PTAL @quoctruong |
@etanshaul too |
Closing. Will re-open as smaller pieces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3122
Fixes #2211
Description
Implements two events to notify of a debugging container being started and terminated. Also exposes a list of currently running debugging containers via the Skaffold state object. The IDEs can monitor for events to populate UIs.
`/v1/events` stream of `skaffold debug` within `examples/jib`
In this example, we do a
skaffold debug
, and then kill the deployed pod. The deployment starts a new pod. We get a terminated event for the container for the killed pod.The `/v1/state` listing debugging containers
User facing changes
n/a
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Adds documentation as needed: user docs, YAML reference, CLI reference.Reviewer Notes
Release Notes
n/a — for internal consumption