Skip to content

Allow 2020 copyright year #3511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Conversation

loosebazooka
Copy link
Member

@loosebazooka loosebazooka commented Jan 15, 2020

Allows 2019|2020.

Previously when only 2019 was used, it was a hard requirement that all files use 2019, so any new file added would require a 2019 copyright header.

With this change, there will not be a way to ensure that new files use 2020 except by human 👀 but we preserve the original copyright year on files that were created earlier than 2020.

@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #3511 into master will not change coverage.
The diff coverage is n/a.

@balopat
Copy link
Contributor

balopat commented Jan 15, 2020

Thanks for this :) yeah, I think that's fine / I can modify the script to ensure year of creation = today's year.
Last year I kinda messed this up and updated the copyright year to 2019 on all files, I might fix that with this change, as I learned that the policy is to keep the copyright year the creation year.

@balopat balopat merged commit 3edcf53 into master Jan 15, 2020
@chanseokoh chanseokoh deleted the update-boilerplate-copyright-year branch January 15, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants