Skip to content

[init refactor] organize tests #3542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 21, 2020
Merged

[init refactor] organize tests #3542

merged 3 commits into from
Jan 21, 2020

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Jan 20, 2020 •
edited
Loading

This should come after #3538 is merged, it's built on top of that.

  • It reorganizes the tests from init_test.go to the relevant file's tests.
  • adds tests for stripTags that is a new method introduced as I'm starting to take DoInit apart

I know...this is a bit bigger but I am close to getting to a sensible organization of the code.
Also, after merging #3538 this should become smaller.

@balopat balopat force-pushed the init_refactor/organize_tests branch from 2acd1fa to 4b0ee1f Compare January 20, 2020 23:49
@codecov
Copy link

codecov bot commented Jan 20, 2020 •
edited
Loading

Codecov Report

Merging #3542 into master will increase coverage by 0.18%.
The diff coverage is 68.65%.

Impacted Files Coverage Δ
pkg/skaffold/initializer/init.go 0% <0%> (ø) ⬆️
pkg/skaffold/initializer/prompt.go 0% <0%> (ø) ⬆️
pkg/skaffold/initializer/builders.go 94.2% <100%> (+0.76%) ⬆️
pkg/skaffold/initializer/config.go 100% <100%> (ø) ⬆️
pkg/skaffold/initializer/analyze.go 87.23% <93.33%> (+4.88%) ⬆️
pkg/skaffold/build/jib/sync.go 61.53% <0%> (ø)
pkg/skaffold/schema/defaults/defaults.go 94.38% <0%> (+0.12%) ⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0%> (+2.43%) ⬆️

@balopat balopat force-pushed the init_refactor/organize_tests branch from 4b0ee1f to d0d9930 Compare January 21, 2020 06:28
@balopat
Copy link
Contributor Author

balopat commented Jan 21, 2020

Thank you for all the reviews @dgageot! You are a rock star! ⭐️

dgageot
dgageot approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@dgageot dgageot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few nits

@balopat balopat mentioned this pull request Jan 21, 2020
Merged
@balopat balopat merged commit 7dc8e10 into GoogleContainerTools:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgageot dgageot dgageot approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balopat @dgageot @googlebot