Skip to content

migrate Deployment from extensions/v1beta1 to apps/v1 #3572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2020
Merged

migrate Deployment from extensions/v1beta1 to apps/v1 #3572

merged 1 commit into from
Jan 24, 2020

Conversation

oke-py
Copy link
Contributor

@oke-py oke-py commented Jan 24, 2020

Fixes #3552

Description

migrate Deployment from extensions/v1beta1 to apps/v1

User facing changes

n/a

Before

n/a

After

n/a

Next PRs.

n/a

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #3572 into master will not change coverage.
The diff coverage is n/a.

@dgageot
Copy link
Contributor

dgageot commented Jan 24, 2020

Thanks a lot @oke-py! I had not realised we still had those around.

@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Jan 24, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jan 24, 2020
@balopat balopat merged commit 818c721 into GoogleContainerTools:master Jan 24, 2020
@oke-py oke-py deleted the apps/v1 branch January 24, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extensions/v1beta1 Deployment should be migrated to apps/v1
5 participants