Skip to content

Prevent nil pointer dereference #3594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Prevent nil pointer dereference #3594

wants to merge 1 commit into from

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jan 27, 2020

Not sure how this can happen but this has happened.

I will try to reproduce and add tests around that code.

Signed-off-by: David Gageot [email protected]

balopat
balopat suggested changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the NewGcloudAuthenticator error handling (the lack of it) is adding to the problem. In L87 we might fail with an error, then go to defaultkeychain which then returns nil ...
Let's reproduce the issue and understand it deeper.

@balopat balopat self-assigned this Jan 27, 2020
@codecov
Copy link

codecov bot commented Jan 27, 2020 •
edited
Loading

Codecov Report

Merging #3594 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted Files Coverage Δ
pkg/skaffold/docker/authenticators.go 65.51% <0%> (ø) ⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0%> (-2.44%) ⬇️

@dgageot
Copy link
Contributor Author

dgageot commented Jan 27, 2020

@balopat yes, you're right.

@dgageot
Copy link
Contributor Author

dgageot commented Jan 28, 2020

Closing in favour of #3597

@dgageot dgageot closed this Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat requested changes

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees

@balopat balopat

Labels
cla: yes pr/changes-requested size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @balopat @googlebot