Skip to content

Prepare v2alpha4 #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2020
Merged

Prepare v2alpha4 #3635

merged 1 commit into from
Feb 18, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Feb 3, 2020

Signed-off-by: David Gageot [email protected]

@codecov
Copy link

codecov bot commented Feb 3, 2020 •
edited
Loading

Codecov Report

Merging #3635 into master will decrease coverage by <.01%.
The diff coverage is 84.61%.

Impacted Files Coverage Δ
pkg/skaffold/schema/v2alpha2/upgrade.go 85.71% <ø> (ø) ⬆️
pkg/skaffold/schema/versions.go 73.07% <ø> (ø) ⬆️
pkg/skaffold/schema/latest/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/schema/v2alpha3/config.go 100% <100%> (ø)
pkg/skaffold/schema/v2alpha3/upgrade.go 77.77% <77.77%> (ø)
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0%> (-2.44%) ⬇️

@balopat
Copy link
Contributor

balopat commented Feb 3, 2020

Do you have a config change in the next two weeks that motives the bump?

@dgageot
Copy link
Contributor Author

dgageot commented Feb 3, 2020

@balopat not that I know. I was trying to see if it worked for when we are going to need it. And it's not straightforward. See #3633

@balopat
Copy link
Contributor

balopat commented Feb 3, 2020

Sounds good, yes we should fix the script. I just want to avoid merging this and causing unnecessary version bumps! Thank you for the exploration! Let's wait with merging this until we have a config change!

tejal29
tejal29 previously requested changes Feb 3, 2020
View reviewed changes
docs/content/en/schemas/v2alpha3.json Outdated
@@ -1606,7 +1606,7 @@
"type": "array",
"description": "path to Kustomization files.",
"x-intellij-html-description": "path to Kustomization files.",
"default": "[\".\"]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change caused #3618
https://github.com/GoogleContainerTools/skaffold/pull/3620/files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgageot should this be removed?

@zasgar zasgar mentioned this pull request Feb 4, 2020
Closed
7 tasks
@loosebazooka loosebazooka mentioned this pull request Feb 6, 2020
Merged
@loosebazooka
Copy link
Member

Meant to ping this last week. Can we merge this? There are some changes queued that require it now.

nkubala
nkubala suggested changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgageot can you check out the change to the previous schema version and see if we need it? then we should merge this

docs/content/en/schemas/v2alpha3.json Outdated
@@ -1606,7 +1606,7 @@
"type": "array",
"description": "path to Kustomization files.",
"x-intellij-html-description": "path to Kustomization files.",
"default": "[\".\"]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgageot should this be removed?

@dgageot
Copy link
Contributor Author

dgageot commented Feb 17, 2020

@nkubala @loosebazooka This should be good now

@dgageot
Prepare v2alpha4
95b81c1 
Signed-off-by: David Gageot <[email protected]>
@nkubala nkubala added the kokoro:run runs the kokoro jobs on a PR label Feb 18, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Feb 18, 2020
@nkubala nkubala merged commit 195d6fc into GoogleContainerTools:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala approved these changes

@tejal29 tejal29 tejal29 left review comments

@balopat balopat Awaiting requested review from balopat

@briandealwis briandealwis Awaiting requested review from briandealwis

@chanseokoh chanseokoh Awaiting requested review from chanseokoh

@loosebazooka loosebazooka Awaiting requested review from loosebazooka

@TadCordle TadCordle Awaiting requested review from TadCordle

Assignees
No one assigned
Labels
cla: yes size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dgageot @balopat @loosebazooka @tejal29 @nkubala @googlebot @kokoro-team