-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Support skaffold fix —version skaffold/v1
#4016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
|
Please visit http://34.94.104.146:1313 to view changes to the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM excpet for doc changes
-
http://34.94.104.146:1313/docs/references/cli/#skaffold-fix the description needs to change from
"Update old configuration to newest schema version" to "Update old configuration to newest or specified schema version" -
Not your fault, but on the CLI page, the description for skaffild fix is incomplete
http://34.94.104.146:1313/docs/references/cli/
skaffold fix - to upgrade from
Fixes GoogleContainerTools#3613 Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Fixes #3613
Also took the opportunity to:
skaffold fix
Signed-off-by: David Gageot [email protected]