Skip to content

Support skaffold fix —version skaffold/v1 #4016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Apr 23, 2020

Fixes #3613

Also took the opportunity to:

  • improve the code a bit
  • add more unit tests
  • add examples of usage for skaffold fix
  • improve error messages

Signed-off-by: David Gageot [email protected]

@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #4016 into master will increase coverage by 0.02%.
The diff coverage is 85.29%.

Impacted Files Coverage Δ
pkg/skaffold/runner/generate_pipeline.go 0.00% <0.00%> (ø)
pkg/skaffold/schema/versions.go 82.75% <86.36%> (+7.75%) ⬆️
cmd/skaffold/app/cmd/fix.go 70.58% <87.50%> (+2.84%) ⬆️
cmd/skaffold/app/cmd/find_configs.go 45.71% <100.00%> (ø)
cmd/skaffold/app/cmd/runner.go 75.00% <100.00%> (ø)
pkg/skaffold/schema/latest/upgrade.go 100.00% <100.00%> (ø)
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0.00%> (-2.44%) ⬇️

@tejal29 tejal29 added meta/docs-preview docs-modifications runs the docs preview service on the given PR and removed meta/docs-preview labels Apr 23, 2020
@container-tools-bot
Copy link

Please visit http://34.94.104.146:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Apr 23, 2020
Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM excpet for doc changes

  1. http://34.94.104.146:1313/docs/references/cli/#skaffold-fix the description needs to change from
    "Update old configuration to newest schema version" to "Update old configuration to newest or specified schema version"

  2. Not your fault, but on the CLI page, the description for skaffild fix is incomplete
    http://34.94.104.146:1313/docs/references/cli/

skaffold fix - to upgrade from

@dgageot dgageot requested a review from briandealwis as a code owner April 24, 2020 18:10
dgageot added 3 commits April 26, 2020 10:18
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
@dgageot dgageot merged commit f40dcd4 into GoogleContainerTools:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can skaffold fix take a flag to specify which schema version to transform to?
5 participants