Skip to content

Add CLI option --profile-auto-activation to allow disabling automatic profile activation. #4034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2020

Conversation

gsquared94
Copy link
Contributor

Add CLI option --profile-auto-activation to allow disabling automatic profile activation. Instead profiles need to be explicitly specified using --profile

Fixes: #3988

Description

Add CLI option --profile-auto-activation that is true by default. Setting to false will disable automatic profile activation and profiles will need to be explicitly specified using --profile

…ic profile activation. Instead profiles need to be explicitly specified using `--profile`
@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #4034 into master will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 100.00% <ø> (ø)
pkg/skaffold/config/options.go 100.00% <ø> (ø)
pkg/skaffold/schema/profiles.go 90.96% <85.71%> (+0.05%) ⬆️

# Conflicts:
#	pkg/skaffold/config/options.go
@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Apr 28, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Apr 28, 2020
@dgageot dgageot merged commit e70405a into GoogleContainerTools:master Apr 28, 2020
@gsquared94 gsquared94 deleted the gaghosh-issue-3988 branch April 28, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants