Skip to content

allow specifying regex in global config kubecontext #4076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2020
Merged

allow specifying regex in global config kubecontext #4076

merged 1 commit into from
May 18, 2020

Conversation

DanielSel
Copy link
Contributor

Replicate the kubecontext matching behaviour from profiles to global config

@codecov
Copy link

codecov bot commented Apr 30, 2020 •
edited
Loading

Codecov Report

Merging #4076 into master will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/config/set.go 88.63% <100.00%> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <100.00%> (ø)
pkg/skaffold/config/util.go 69.50% <100.00%> (ø)
pkg/skaffold/schema/profiles.go 90.80% <100.00%> (-0.64%) ⬇️
pkg/skaffold/util/regex.go 100.00% <100.00%> (ø)
pkg/skaffold/runner/portforwarder.go 30.00% <0.00%> (-70.00%) ⬇️
...skaffold/kubernetes/debugging/container_manager.go 44.61% <0.00%> (-3.72%) ⬇️
...affold/kubernetes/portforward/forwarder_manager.go 28.57% <0.00%> (-3.01%) ⬇️
cmd/skaffold/app/cmd/cmd.go 65.24% <0.00%> (-2.18%) ⬇️
pkg/skaffold/runner/new.go 68.96% <0.00%> (-1.04%) ⬇️
... and 12 more

@DanielSel DanielSel force-pushed the feature/global-kubecontext-regex branch from 8662cf7 to 6a33178 Compare April 30, 2020 16:20
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 30, 2020
@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label May 2, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label May 2, 2020
balopat
balopat suggested changes May 4, 2020
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I would request is to add this to the documentation here, otherwise we'll forget to document it:
https://skaffold.dev/docs/design/global-config/

nkubala
nkubala reviewed May 5, 2020
View reviewed changes
@dgageot
Copy link
Contributor

dgageot commented May 9, 2020

@DanielSel There's just a few nits and some doc to be added

@DanielSel DanielSel force-pushed the feature/global-kubecontext-regex branch 2 times, most recently from 7f1358b to 2c45d65 Compare May 14, 2020 18:12
@DanielSel DanielSel requested a review from balopat May 14, 2020 18:15
@DanielSel
Copy link
Contributor Author

The only thing I would request is to add this to the documentation here, otherwise we'll forget to document it:
https://skaffold.dev/docs/design/global-config/

done. sorry for the delay.

@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label May 16, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label May 16, 2020
balopat
balopat previously requested changes May 16, 2020
View reviewed changes
@DanielSel DanielSel force-pushed the feature/global-kubecontext-regex branch from 2c45d65 to 5d3e0f3 Compare May 16, 2020 21:06
@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label May 18, 2020
@tejal29 tejal29 self-assigned this May 18, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label May 18, 2020
@tejal29 tejal29 added the docs-modifications runs the docs preview service on the given PR label May 18, 2020
@container-tools-bot
Copy link

Please visit http://34.94.121.254:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label May 18, 2020
@tejal29
Copy link
Contributor

tejal29 commented May 18, 2020

Please visit http://34.94.121.254:1313 to view changes to the docs.

Checked the docs.

@tejal29 tejal29 dismissed balopat’s stale review May 18, 2020 20:54

added docs.

@tejal29 tejal29 merged commit db6631e into GoogleContainerTools:master May 18, 2020
@fmotrifork fmotrifork mentioned this pull request May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala left review comments

@dgageot dgageot dgageot approved these changes

@tejal29 tejal29 tejal29 approved these changes

@balopat balopat balopat left review comments

@briandealwis briandealwis Awaiting requested review from briandealwis

Assignees

@tejal29 tejal29

Labels
cla: yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@DanielSel @dgageot @container-tools-bot @tejal29 @balopat @nkubala @googlebot @kokoro-team