Skip to content

Remove duplication around kubectlCLI #4215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented May 18, 2020

Signed-off-by: David Gageot [email protected]

Signed-off-by: David Gageot <[email protected]>
@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #4215 into master will increase coverage by 0.02%.
The diff coverage is 50.00%.

Impacted Files Coverage Δ
pkg/skaffold/runner/debugging.go 75.00% <0.00%> (+32.14%) ⬆️
pkg/skaffold/runner/logger.go 42.85% <0.00%> (+5.35%) ⬆️
pkg/skaffold/runner/portforwarder.go 30.00% <0.00%> (ø)
pkg/skaffold/runner/runner.go 0.00% <ø> (ø)
pkg/skaffold/runner/kind.go 100.00% <100.00%> (ø)
pkg/skaffold/runner/new.go 69.35% <100.00%> (+0.50%) ⬆️

@dgageot
Copy link
Contributor Author

dgageot commented May 19, 2020

Self merging this small refactoring

@dgageot dgageot merged commit 202f9fc into GoogleContainerTools:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants