Skip to content

Collapse ImagePullBackOff and ErrImagePullBackOff together #4269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 29, 2020
Merged

Collapse ImagePullBackOff and ErrImagePullBackOff together #4269

merged 2 commits into from
May 29, 2020

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented May 27, 2020

Relates to: #3917

Both ErrImagePullBackOff and ImagePullBackOff could appear in the Reason string.

Hence combining them together.

@tejal29 tejal29 mentioned this pull request May 27, 2020
Merged
7 tasks
@codecov
Copy link

codecov bot commented May 27, 2020 •
edited
Loading

Codecov Report

Merging #4269 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/server/server.go 53.65% <0.00%> (ø)
...affold/kubernetes/portforward/kubectl_forwarder.go 63.41% <0.00%> (+2.43%) ⬆️

@balopat balopat merged commit fc25f6b into GoogleContainerTools:master May 29, 2020
@fmotrifork fmotrifork mentioned this pull request Jun 12, 2020
Merged
@tejal29 tejal29 deleted the small_upgrades branch April 15, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgageot dgageot dgageot approved these changes

@briandealwis briandealwis briandealwis approved these changes

@balopat balopat Awaiting requested review from balopat

@nkubala nkubala Awaiting requested review from nkubala

@tstromberg tstromberg Awaiting requested review from tstromberg

Assignees
No one assigned
Labels
cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tejal29 @dgageot @briandealwis @balopat @googlebot