Skip to content

Setup Github Actions for testing release binary against linux and darwin #4300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gsquared94
Copy link
Contributor

@gsquared94 gsquared94 commented Jun 8, 2020

Runs integration tests at 10 AM UTC every day against the release bits of skaffold in ubuntu and macos. Uses minikube instead of kind.

We can later add badges:
release(linux) release(darwin)

@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #4300 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4300   +/-   ##
=======================================
  Coverage   71.91%   71.91%           
=======================================
  Files         322      322           
  Lines       12312    12313    +1     
=======================================
+ Hits         8854     8855    +1     
  Misses       2897     2897           
  Partials      561      561           
Impacted Files Coverage Δ
pkg/skaffold/build/cluster/pod.go 87.57% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f914090...9638b30. Read the comment docs.

@gsquared94 gsquared94 added the kokoro:run runs the kokoro jobs on a PR label Jun 8, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jun 8, 2020
@briandealwis
Copy link
Member

Cool! But why 10am UTC? That’s mid-day for @dgageot!

@briandealwis
Copy link
Member

I take it back: 10:00 UTC is brilliant since it's early enough to fix same-day.

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm new to Github Actions so excuse naïve questions. Can we create reuseable scripts with pluggable values? Wondering if we can create parallel tests to verify compatibility with our minimum supported versions.

@gsquared94 gsquared94 requested a review from briandealwis June 10, 2020 20:31
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, let's follow up and see if we have any options for testing against windows

@gsquared94 gsquared94 added the kokoro:run runs the kokoro jobs on a PR label Jun 10, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jun 10, 2020
@gsquared94 gsquared94 merged commit 198fcee into GoogleContainerTools:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nightly integration tests against Linux, Windows and OSX
6 participants