Skaffold init supports Python projects with Buildpacks
#4309
Conversation
dgageot
requested review from
balopat,
briandealwis,
nkubala and
tejal29
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4309 +/- ##
=======================================
Coverage 71.95% 71.96%
=======================================
Files 323 323
Lines 12395 12404 +9
=======================================
+ Hits 8919 8926 +7
- Misses 2912 2913 +1
- Partials 564 565 +1
Continue to review full report at Codecov.
|
|
ping @nkubala @briandealwis |
| artifacts: | ||
| - image: skaffold-buildpacks | ||
| buildpacks: | ||
| builder: "gcr.io/buildpacks/builder" |
There was a problem hiding this comment.
In light of #4313, this should be with :v1
| case file == "requirements.txt": | ||
| if _, err := os.Stat(filepath.Join(filepath.Dir(path), "Procfile")); err == nil { | ||
| valid = true | ||
| } |
There was a problem hiding this comment.
The boolean return doesn't quite capture enough. We should be able to return output a message here along the lines of "...$path seems to be a Python project, but Buildpacks requires a Procfile". Or maybe this framework needs the ability to register a follow-up action (REQUIRES_PROCFILE) so that the CLI/UI/IDE can offer the user some detail as to why it failed.
A todo for now is fine.
Signed-off-by: David Gageot <[email protected]>
dgageot
force-pushed
the
python-buildpack
branch
from
864e692 to
5187bdd
Compare
Signed-off-by: David Gageot [email protected]