Skip to content

Get digest of multi-arch images #4475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2020
Merged

Get digest of multi-arch images #4475

merged 1 commit into from
Jul 25, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jul 15, 2020

Fix #4156

@dgageot dgageot requested a review from a team as a code owner July 15, 2020 11:06
@dgageot dgageot requested a review from gsquared94 July 15, 2020 11:06
@codecov
Copy link

codecov bot commented Jul 15, 2020 •
edited
Loading

Codecov Report

Merging #4475 into master will increase coverage by 0.07%.
The diff coverage is 85.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4475      +/-   ##
==========================================
+ Coverage   72.61%   72.69%   +0.07%     
==========================================
  Files         335      335              
  Lines       12963    12971       +8     
==========================================
+ Hits         9413     9429      +16     
+ Misses       2957     2949       -8     
  Partials      593      593
Impacted Files Coverage Δ
pkg/skaffold/docker/remote.go 53.44% <85.00%> (+23.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d53d1...b2cb956. Read the comment docs.

@dgageot dgageot marked this pull request as draft July 15, 2020 16:49
@dgageot dgageot force-pushed the fix-4156 branch 3 times, most recently from fcafc16 to 18aa033 Compare July 23, 2020 06:59
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 23, 2020
@dgageot dgageot marked this pull request as ready for review July 23, 2020 08:52
@dgageot
Copy link
Contributor Author

dgageot commented Jul 24, 2020

@briandealwis could you TAL?

@dgageot dgageot merged commit 2fedbae into GoogleContainerTools:master Jul 25, 2020
@fmotrifork fmotrifork mentioned this pull request Aug 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala approved these changes

@gsquared94 gsquared94 Awaiting requested review from gsquared94

Assignees
No one assigned
Labels
cla: yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image for incorrect architecture being used
3 participants
@dgageot @nkubala @googlebot