-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Support short build logs #4528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Support short build logs #4528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4528 +/- ##
==========================================
+ Coverage 72.73% 72.74% +0.01%
==========================================
Files 335 336 +1
Lines 13016 13037 +21
==========================================
+ Hits 9467 9484 +17
- Misses 2950 2953 +3
- Partials 599 600 +1
Continue to review full report at Codecov.
|
ff30ff1
to
15fc966
Compare
MarlonGamez
reviewed
Jul 23, 2020
7633194
to
c1987bf
Compare
c1987bf
to
58b826e
Compare
176cb17
to
f386e2d
Compare
nkubala
reviewed
Jul 28, 2020
d459ab0
to
dd3ae24
Compare
Signed-off-by: David Gageot <[email protected]>
dd3ae24
to
7147ed0
Compare
briandealwis
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an option for shorter output for the build phase.
Instead of always printing the full build log, it prints the path to a log file, logs the output to that file and only print the full output to the console if the build failed.
Signed-off-by: David Gageot [email protected]