Skip to content

Support short build logs #4528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jul 22, 2020

This PR introduces an option for shorter output for the build phase.

Instead of always printing the full build log, it prints the path to a log file, logs the output to that file and only print the full output to the console if the build failed.

Signed-off-by: David Gageot [email protected]

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #4528 into master will increase coverage by 0.01%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4528      +/-   ##
==========================================
+ Coverage   72.73%   72.74%   +0.01%     
==========================================
  Files         335      336       +1     
  Lines       13016    13037      +21     
==========================================
+ Hits         9467     9484      +17     
- Misses       2950     2953       +3     
- Partials      599      600       +1     
Impacted Files Coverage Δ
pkg/skaffold/build/cluster/cluster.go 26.47% <0.00%> (-0.81%) ⬇️
pkg/skaffold/build/gcb/cloud_build.go 0.00% <0.00%> (ø)
pkg/skaffold/build/logfile.go 86.66% <86.66%> (ø)
pkg/skaffold/build/cluster/types.go 100.00% <100.00%> (ø)
pkg/skaffold/build/gcb/types.go 42.85% <100.00%> (+4.39%) ⬆️
pkg/skaffold/build/local/local.go 63.63% <100.00%> (+0.84%) ⬆️
pkg/skaffold/build/local/types.go 86.66% <100.00%> (+0.45%) ⬆️
pkg/skaffold/build/parallel.go 93.93% <100.00%> (ø)
pkg/skaffold/build/sequence.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a7edd8...7147ed0. Read the comment docs.

@dgageot dgageot force-pushed the short-build-logs branch 3 times, most recently from ff30ff1 to 15fc966 Compare July 23, 2020 12:25
@dgageot dgageot force-pushed the short-build-logs branch 4 times, most recently from 7633194 to c1987bf Compare July 27, 2020 12:10
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 27, 2020
@dgageot dgageot force-pushed the short-build-logs branch from c1987bf to 58b826e Compare July 27, 2020 13:29
@dgageot dgageot marked this pull request as ready for review July 27, 2020 16:08
@dgageot dgageot requested a review from a team as a code owner July 27, 2020 16:08
@dgageot dgageot requested a review from tejal29 July 27, 2020 16:08
@dgageot dgageot force-pushed the short-build-logs branch 2 times, most recently from 176cb17 to f386e2d Compare July 28, 2020 05:45
@dgageot dgageot added the kokoro:force-run forces a kokoro re-run on a PR label Jul 28, 2020
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jul 28, 2020
@dgageot dgageot force-pushed the short-build-logs branch 4 times, most recently from d459ab0 to dd3ae24 Compare July 28, 2020 20:29
Signed-off-by: David Gageot <[email protected]>
@dgageot dgageot force-pushed the short-build-logs branch from dd3ae24 to 7147ed0 Compare July 29, 2020 15:26
@dgageot dgageot merged commit aa85937 into GoogleContainerTools:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants