Tag template tagger #4567
Merged
Tag template tagger #4567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4567 +/- ##
==========================================
+ Coverage 72.61% 72.83% +0.21%
==========================================
Files 335 334 -1
Lines 12963 13037 +74
==========================================
+ Hits 9413 9495 +82
+ Misses 2957 2945 -12
- Partials 593 597 +4
Continue to review full report at Codecov.
|
yuwenma
reviewed
Jul 27, 2020
|
Overall LGTM. |
nkubala
suggested changes
Jul 28, 2020
Co-authored-by: Nick Kubala <[email protected]>
Co-authored-by: Nick Kubala <[email protected]>
nkubala
approved these changes
Jul 29, 2020
briandealwis
added a commit
to briandealwis/skaffold
that referenced
this pull request
Jul 8, 2021
with the -beta.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: Issue: #4371, #4550
Description
This includes the coding logic for the new tagging strategy
tagTemplate. This code is only exercised in tests and will not be exposed to users until the following PR.tagTemplateallows users to create their own tags by specifying a template composed of pre-existing tagging strategies. These pre-existing tagging strategies are stored as tagger objects under the components field and evaluated when the tag is generated.Follow-up Work
There will be a follow-up PR exposing this feature to users which includes changes to the Skaffold config as well as the necessary changes to any documentation.