Make event handling sequential and set the correct timestamp #4644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4644 +/- ##
==========================================
+ Coverage 73.15% 73.18% +0.02%
==========================================
Files 337 337
Lines 13294 13308 +14
==========================================
+ Hits 9725 9739 +14
Misses 2958 2958
Partials 611 611
Continue to review full report at Codecov.
|
tejal29
approved these changes
Aug 11, 2020
nkubala
pushed a commit
to nkubala/skaffold
that referenced
this pull request
Aug 20, 2020
Make event handling sequential and set the correct timestamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #4578
Description
Log events are coming out of order and with incorrect timestamps:
This fix makes all event handle go through a single goroutine and also updates timestamps to when the events actually occur vs when they are handled.
This results in the correct event order and timestamp: