Enabling '--secret' option in 'docker build' #4659
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a feature addition related to issue GoogleContainerTools#2273.
|
@nkubala You were working on this right. Are you planning to use this approach or use existing |
|
@h-michael I realized you had submitted this as I was finishing up my PR last week, sorry! I had meant to get this earlier and then point you to it as a way to model your other PR you have open. let me get mine merged, and then if you can get your other PR to look similar to mine (config change + docs + tests), we can merge it quickly. |
|
@h-michael yes please! i'm gonna merge #4731 probably today, if you get #4660 to look like this one we can get it merged quickly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature addition related to issue #2273.
Related: #2273
Description
This is PR for the addition of a feature that allows us to use the
docker build --secretoption.Docker document link
Should I make sure to check the
useBuildkitoption?