Suppress clutter from docker-credential-gcloud error messages #4705
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows on #4451
Description
The change in #4451 makes Skaffold's image-pulling follow the approach used with
docker pull
: first try with credentials, and then without credentials. When pulling from GCR, that first pull may result in an error being emitted fromdocker-credential-gcloud
when there is no user or credentials have been revoked.This happens surprisingly often — even when users have not run
gcloud auth configure-docker
— as Skaffold tries usingdocker-credential-gcloud
for *.gcr.io. This is the case with Cloud Code as the Cloud SDK is automatically installed, but users may not yet have performed an action requiring authentication (e.g., to deploy to GCP).This PR sets
CLOUDSDK_CORE_VERBOSITY=none
prior to pulling images to suppress error messages emitted fromdocker-credential-gcloud
. These messages are unnecessary as should the image pull fail, the error reported from the registry and shown to the user contains sufficient information to rectify the situation.Before:
Now:
Error when pulling from a private repository: