Skip to content

Add test for using helm setFiles #4735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

MarlonGamez
Copy link
Contributor

This PR only adds a simple test to check that using setFiles in the helm deployer stanza adds the proper flag when running helm commands

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #4735 into master will decrease coverage by 0.05%.
The diff coverage is 45.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4735      +/-   ##
==========================================
- Coverage   73.39%   73.34%   -0.06%     
==========================================
  Files         344      345       +1     
  Lines       13669    13708      +39     
==========================================
+ Hits        10033    10054      +21     
- Misses       3002     3021      +19     
+ Partials      634      633       -1     
Impacted Files Coverage Δ
pkg/diag/validator/pod.go 1.60% <0.00%> (-0.08%) ⬇️
pkg/skaffold/runner/runner.go 0.00% <ø> (ø)
pkg/skaffold/deploy/status_check.go 52.25% <25.53%> (-6.81%) ⬇️
pkg/skaffold/runner/deploy.go 44.77% <50.00%> (ø)
pkg/skaffold/deploy/resource/logfile.go 84.61% <84.61%> (ø)
pkg/skaffold/deploy/resource/deployment.go 91.54% <88.00%> (+1.54%) ⬆️
pkg/skaffold/deploy/helm.go 79.03% <0.00%> (+0.80%) ⬆️
pkg/diag/validator/resource.go 58.82% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53dffe1...1a23dcd. Read the comment docs.

@MarlonGamez MarlonGamez marked this pull request as ready for review August 28, 2020 21:12
@MarlonGamez MarlonGamez requested a review from a team as a code owner August 28, 2020 21:12
@MarlonGamez MarlonGamez requested a review from tejal29 August 28, 2020 21:12
@MarlonGamez
Copy link
Contributor Author

Codecov seems to be behaving oddly on this PR. @tejal29 pointed out that it has the same diffs as a PR that she merged earlier #4690

@gsquared94 gsquared94 merged commit e4ec899 into GoogleContainerTools:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants