Skip to content

Hide minikube detection behind flag #4745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2020

Conversation

gsquared94
Copy link
Contributor

Add flag --detect-minikube which is false by default.

@gsquared94 gsquared94 requested a review from a team as a code owner August 31, 2020 18:45
@gsquared94 gsquared94 requested a review from dgageot August 31, 2020 18:45
@gsquared94 gsquared94 requested review from nkubala and removed request for dgageot August 31, 2020 18:45
@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #4745 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4745   +/-   ##
=======================================
  Coverage   73.41%   73.42%           
=======================================
  Files         345      345           
  Lines       13750    13755    +5     
=======================================
+ Hits        10095    10100    +5     
  Misses       3022     3022           
  Partials      633      633           
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 86.36% <ø> (ø)
pkg/skaffold/config/options.go 100.00% <ø> (ø)
pkg/skaffold/build/local/types.go 86.66% <100.00%> (ø)
pkg/skaffold/config/util.go 69.94% <100.00%> (+0.63%) ⬆️
pkg/skaffold/runner/runcontext/context.go 86.07% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b642a69...859d532. Read the comment docs.

@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Aug 31, 2020
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Aug 31, 2020
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can probably remove this flag and enable this by default in the v1.15.0 release.

@nkubala nkubala merged commit b91bfbe into GoogleContainerTools:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants