Skip to content

Doc update; new example; new tutorial for artifact dependencies #4971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 31, 2020
Merged

Doc update; new example; new tutorial for artifact dependencies #4971

merged 5 commits into from
Oct 31, 2020

Conversation

gsquared94
Copy link
Contributor

@gsquared94 gsquared94 commented Oct 29, 2020 •
edited
Loading

Fixes #4967, Related #4713

  • [Website] Updates the Docker builder docs with details about artifact dependency resolution as build-args
  • Add new example simple-artifact-dependency
  • [Website] Add tutorial about artifact dependency feature using simple-artifact-dependency

@gsquared94 gsquared94 requested a review from a team as a code owner October 29, 2020 14:29
@gsquared94 gsquared94 requested a review from nkubala October 29, 2020 14:29
@google-cla google-cla bot added the cla: yes label Oct 29, 2020
@gsquared94 gsquared94 added the docs-modifications runs the docs preview service on the given PR label Oct 29, 2020
@container-tools-bot
Copy link

Please visit http://34.94.209.155:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Oct 29, 2020
@gsquared94
Copy link
Contributor Author

Specifically: http://34.94.209.155:1313/docs/tutorials/artifact-dependencies/

@codecov
Copy link

codecov bot commented Oct 29, 2020 •
edited
Loading

Codecov Report

Merging #4971 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4971   +/-   ##
=======================================
  Coverage   72.27%   72.27%           
=======================================
  Files         361      361           
  Lines       12640    12640           
=======================================
  Hits         9135     9135           
  Misses       2827     2827           
  Partials      678      678

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcdf77c...c84e8ef. Read the comment docs.

@MarlonGamez
Copy link
Contributor

This looks good! I would maybe like to maybe see what the output looks like when running skaffold build at the end of the page, not sure if others feel the same?

@gsquared94 gsquared94 added the docs-modifications runs the docs preview service on the given PR label Oct 29, 2020
@container-tools-bot
Copy link

Please visit http://34.94.166.254:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Oct 29, 2020
@gsquared94
Copy link
Contributor Author

perhaps I should add a top level doc also.

@gsquared94 gsquared94 marked this pull request as draft October 29, 2020 18:44
tejal29
tejal29 previously requested changes Oct 29, 2020
View reviewed changes
@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 30, 2020
@gsquared94 gsquared94 changed the title add tutorial for microservices example with artifact dependencies add tutorial for artifact dependencies Oct 30, 2020
@gsquared94 gsquared94 requested a review from tejal29 October 30, 2020 17:01
@gsquared94 gsquared94 marked this pull request as ready for review October 30, 2020 17:01
@gsquared94 gsquared94 added the docs-modifications runs the docs preview service on the given PR label Oct 30, 2020
@gsquared94 gsquared94 changed the title add tutorial for artifact dependencies Doc update; new example; new tutorial for artifact dependencies Oct 30, 2020
@container-tools-bot
Copy link

Please visit http://34.94.209.155:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Oct 30, 2020
MarlonGamez
MarlonGamez approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the new tutorial is nice!

@gsquared94 gsquared94 dismissed tejal29’s stale review October 31, 2020 02:06

Implemented suggested changes.

@gsquared94 gsquared94 merged commit eace20c into GoogleContainerTools:master Oct 31, 2020
@gsquared94 gsquared94 added this to the v1.17.0 milestone Nov 6, 2020
@fmotrifork fmotrifork mentioned this pull request Nov 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarlonGamez MarlonGamez MarlonGamez approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

@briandealwis briandealwis Awaiting requested review from briandealwis

Assignees
No one assigned
Labels
cla: yes feature/artifact-dependencies size/L
Projects
None yet
Milestone
v1.17.0
Development

Successfully merging this pull request may close these issues.

Document Artifact dependency feature for dockerfile artifacts.
4 participants
@gsquared94 @container-tools-bot @MarlonGamez @tejal29