Skip to content

add docs for config dependencies feature #5321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 29, 2021
Merged

add docs for config dependencies feature #5321

merged 4 commits into from
Jan 29, 2021

Conversation

gsquared94
Copy link
Contributor

add docs about multi-config support

@gsquared94 gsquared94 requested a review from a team as a code owner January 29, 2021 18:48
@gsquared94 gsquared94 requested a review from IsaacPD January 29, 2021 18:48
@google-cla google-cla bot added the cla: yes label Jan 29, 2021
@codecov
Copy link

codecov bot commented Jan 29, 2021 •
edited
Loading

Codecov Report

Merging #5321 (85f17b6) into master (1cdc543) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5321      +/-   ##
==========================================
+ Coverage   71.79%   71.82%   +0.02%     
==========================================
  Files         390      390              
  Lines       14215    14215              
==========================================
+ Hits        10206    10210       +4     
+ Misses       3257     3255       -2     
+ Partials      752      750       -2
Impacted Files Coverage Δ
pkg/skaffold/util/tar.go 56.00% <0.00%> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cdc543...85f17b6. Read the comment docs.

@IsaacPD IsaacPD added the docs-modifications runs the docs preview service on the given PR label Jan 29, 2021
@container-tools-bot
Copy link

Please visit http://35.235.123.213:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Jan 29, 2021
@gsquared94 gsquared94 added the docs-modifications runs the docs preview service on the given PR label Jan 29, 2021
@container-tools-bot
Copy link

Please visit http://34.94.154.192:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Jan 29, 2021
@gsquared94
Copy link
Contributor Author

changes in:

IsaacPD
IsaacPD reviewed Jan 29, 2021
View reviewed changes
Copy link
Contributor

@IsaacPD IsaacPD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, just one comment

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 29, 2021
@gsquared94 gsquared94 added the docs-modifications runs the docs preview service on the given PR label Jan 29, 2021
@container-tools-bot
Copy link

Please visit http://35.235.123.213:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Jan 29, 2021
@gsquared94 gsquared94 requested a review from IsaacPD January 29, 2021 21:34
IsaacPD
IsaacPD approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@IsaacPD IsaacPD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gsquared94 gsquared94 merged commit 097325d into GoogleContainerTools:master Jan 29, 2021
@fmotrifork fmotrifork mentioned this pull request Feb 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacPD IsaacPD IsaacPD approved these changes

Assignees
No one assigned
Labels
cla: yes feature/multi-configs size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsquared94 @container-tools-bot @IsaacPD