Skip to content

add build-dependencies metric #5330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gsquared94
Copy link
Contributor

Related: #5329

@gsquared94 gsquared94 requested a review from IsaacPD February 1, 2021 21:05
@gsquared94 gsquared94 requested a review from a team as a code owner February 1, 2021 21:05
@google-cla google-cla bot added the cla: yes label Feb 1, 2021
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #5330 (61f080e) into master (1da1bed) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5330      +/-   ##
==========================================
- Coverage   71.82%   71.81%   -0.01%     
==========================================
  Files         392      392              
  Lines       14215    14219       +4     
==========================================
+ Hits        10210    10212       +2     
- Misses       3255     3257       +2     
  Partials      750      750              
Impacted Files Coverage Δ
pkg/skaffold/instrumentation/meter.go 50.00% <0.00%> (-4.17%) ⬇️
pkg/skaffold/instrumentation/types.go 0.00% <ø> (ø)
pkg/skaffold/instrumentation/export.go 74.57% <100.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1da1bed...61f080e. Read the comment docs.

Copy link
Contributor

@IsaacPD IsaacPD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. Could you in this PR or another please run make generate-telemetry-json to update the documentation to detail that we are collecting this info now?

@gsquared94
Copy link
Contributor Author

This all looks good to me. Could you in this PR or another please run make generate-telemetry-json to update the documentation to detail that we are collecting this info now?

make generate-telemetry-json is broken on master:

go run hack/struct-json/main.go -- pkg/skaffold/instrumentation/meter.go docs/content/en/docs/resources/telemetry/metrics.json
panic: field "errHandler" needs comment (all public fields require comments)

goroutine 1 [running]:
main.newDefinition(0xc000017120, 0xa, 0x1199140, 0xc000179100, 0x0, 0x0, 0xc00019d770)
        /Users/gaghosh/Code/Work/fork/skaffold/hack/struct-json/main.go:90 +0x9d7
main.generate(0xc000020180, 0x25, 0x2, 0xc000020180, 0x25, 0x116cd6b, 0x11)
        /Users/gaghosh/Code/Work/fork/skaffold/hack/struct-json/main.go:140 +0x1ab
main.generateJSON(0x1166cfc, 0x1, 0x7ffeefbff80c, 0x25, 0x7ffeefbff832, 0x35, 0x0, 0x0, 0xc00006e058)
        /Users/gaghosh/Code/Work/fork/skaffold/hack/struct-json/main.go:59 +0xa8
main.main()
        /Users/gaghosh/Code/Work/fork/skaffold/hack/struct-json/main.go:53 +0xb3
exit status 2
make: *** [generate-telemetry-json] Error 1

@IsaacPD
Copy link
Contributor

IsaacPD commented Feb 1, 2021

Oh I forgot a comment 😅, that's fine then. It should be fixed after #5324

@gsquared94 gsquared94 force-pushed the build-artifact-dependencies-metric branch from 6c41d38 to bdf8e01 Compare February 2, 2021 20:04
@gsquared94
Copy link
Contributor Author

debug/buildpacks integration test flaking, merging anyways.

@gsquared94 gsquared94 merged commit af3a492 into GoogleContainerTools:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants