Document steps to use sErrors.ErrDef class to provide actionable error messages #5375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @TBBle |
tejal29
added
the
docs-modifications
|
Please visit http://34.94.21.130:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
Codecov Report
@@ Coverage Diff @@
## master #5375 +/- ##
==========================================
+ Coverage 71.61% 71.63% +0.02%
==========================================
Files 394 394
Lines 14305 14305
==========================================
+ Hits 10244 10247 +3
+ Misses 3307 3306 -1
+ Partials 754 752 -2
Continue to review full report at Codecov.
|
gsquared94
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documented steps for contributors to add distinct error codes.
These steps are written from discussion captured here.
e.g. #5088 (comment)
Please review changes to doc here http://34.94.21.130:1313/docs/references/api/grpc/#statuscode
Changes to Makefile: https://github.com/GoogleContainerTools/skaffold/pull/5375/files?short_path=fc2a310#diff-fc2a310fcfedfefb0046def697f932def80cbb1e78c689bc0af3c8eab3e33ece
Thanks
Tejal