-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Handle nil PortForward item on setting defaults #5416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5416 +/- ##
==========================================
- Coverage 71.60% 71.37% -0.23%
==========================================
Files 397 397
Lines 14434 14545 +111
==========================================
+ Hits 10335 10382 +47
- Misses 3333 3390 +57
- Partials 766 773 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR! Have a couple comments but this looks good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good :) Just a small grammar change request
Co-authored-by: Marlon Gamez <[email protected]>
Thanks for making the changes :) Once CI passes I'll approve and merge! |
Fixes: #5363
Description
Handles default-setting with list of
PortForward
s containingnil
item.User facing changes (remove if N/A)
When user run with following
skaffold.yaml
:Then, will get looks like:
parsing skaffold config: setting default values: Config's portForward[0] is empty, Please check if it has valid values