-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add Cluster Internal Service Error code along with runcontext #5491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I think we should avoid passing in a RunContext
and instead follow the spirit of #4598 with Config
interfaces. We can pass in the RunContext as an interface{}
, but the actual code should be trying to cast it to the appropriate config.
Codecov Report
@@ Coverage Diff @@
## master #5491 +/- ##
==========================================
- Coverage 70.64% 70.51% -0.13%
==========================================
Files 411 413 +2
Lines 15858 15992 +134
==========================================
+ Hits 11203 11277 +74
- Misses 3827 3884 +57
- Partials 828 831 +3
Continue to review full report at Codecov.
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
0243bb8
to
db8a6b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing the "Cluster Internal Service Error code"
/cc @gsquared94 Please review! |
) | ||
|
||
var ( | ||
ClusterInternalSystemErr = regexp.MustCompile(".*Internal Server Error") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this is exported only to be used in the error
package. Maybe just move it there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was used in deploy
and deploy/error
package previously and hence exported.
37603cc#diff-a8b4a0e99c70a1b6f90aff684f68c5f25ec7650177441b92ceac2557ae3d9f35R68
and
37603cc#diff-8da1821d1e711320629c6b9807272ea867c0dd81e63186cfb87a9ee087b37465R66
Made private after refactor.
Fixes #5485
Review Order
Config
instead of variables from configskaffoldOpts
in skaffold error package and use runContext Config #5537 - to userunContext
andConfig
for error evaluation instead of singletonskafffoldOpts
package variable.Merge After #5490, #5532, #5537
In this PR, summary of changes
userError
to see if the K8 cluster system error.=== Testing Notes====
Force a Internal System Error via code.
and then