Skip to content

generate v2 proto go files #5546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

MarlonGamez
Copy link
Contributor

@MarlonGamez MarlonGamez commented Mar 12, 2021

Related: #5368, #5422, #5423

Description
Updates dockerfile to generate v2 proto go files for use in skaffold code, as well as related proto file scripts.
Most of the delta is generated files.

**Follow-up Work

  • generate docs files: This is already being done I'm just not copying them into the repo yet as the feature is still under development
  • start emitting these protos: This is my next immediate goal.

@google-cla google-cla bot added the cla: yes label Mar 12, 2021
@MarlonGamez MarlonGamez marked this pull request as ready for review March 12, 2021 23:12
@MarlonGamez MarlonGamez requested a review from a team as a code owner March 12, 2021 23:12
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #5546 (d8c6f69) into master (f241521) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5546      +/-   ##
==========================================
- Coverage   71.39%   71.29%   -0.11%     
==========================================
  Files         400      400              
  Lines       14839    14877      +38     
==========================================
+ Hits        10594    10606      +12     
- Misses       3473     3492      +19     
- Partials      772      779       +7     
Impacted Files Coverage Δ
pkg/skaffold/docker/image.go 78.13% <0.00%> (-1.40%) ⬇️
pkg/skaffold/test/custom/error.go 6.66% <0.00%> (-0.93%) ⬇️
pkg/skaffold/test/custom/custom.go 56.17% <0.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f241521...d8c6f69. Read the comment docs.

@MarlonGamez MarlonGamez merged commit b6455e4 into GoogleContainerTools:master Mar 12, 2021
@MarlonGamez MarlonGamez self-assigned this Mar 16, 2021
@MarlonGamez MarlonGamez added this to the v1.21.0 milestone Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants