Skip to content

Fix setting helm --setFiles for Windows #5648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2021

Conversation

gsquared94
Copy link
Contributor

Fixes #5595

Can be tested against the repro provided here

@gsquared94 gsquared94 requested a review from a team as a code owner April 8, 2021 03:51
@google-cla google-cla bot added the cla: yes label Apr 8, 2021
@gsquared94 gsquared94 requested a review from nkubala April 8, 2021 03:51
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #5648 (574708c) into master (91c4480) will increase coverage by 0.08%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5648      +/-   ##
==========================================
+ Coverage   70.70%   70.79%   +0.08%     
==========================================
  Files         428      436       +8     
  Lines       16199    16334     +135     
==========================================
+ Hits        11454    11563     +109     
- Misses       3900     3920      +20     
- Partials      845      851       +6     
Impacted Files Coverage Δ
pkg/skaffold/deploy/helm/args.go 79.24% <92.30%> (+4.24%) ⬆️
pkg/skaffold/build/jib/init.go 83.05% <0.00%> (-4.45%) ⬇️
pkg/skaffold/color/formatter.go 96.00% <0.00%> (-4.00%) ⬇️
pkg/skaffold/build/jib/jib.go 69.46% <0.00%> (-1.08%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
pkg/skaffold/util/tar.go 56.00% <0.00%> (ø)
pkg/skaffold/runner/tester.go 100.00% <0.00%> (ø)
pkg/skaffold/build/jib/jvm.go 55.55% <0.00%> (ø)
pkg/skaffold/inspect/profiles.go 100.00% <0.00%> (ø)
pkg/skaffold/inspect/modules.go 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91c4480...574708c. Read the comment docs.

@gsquared94 gsquared94 requested a review from briandealwis April 9, 2021 17:28
@ReneWerner87
Copy link

is there a progress in the pull request, under windows no work with multi configurations is possible without this fix

would be cool if you could push this a little bit

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have more questions

@gsquared94 gsquared94 requested a review from briandealwis April 29, 2021 23:39
@gsquared94
Copy link
Contributor Author

gsquared94 commented Apr 29, 2021

I have more questions

Can you take another look @briandealwis ?

@gsquared94 gsquared94 enabled auto-merge (squash) May 4, 2021 01:46
@gsquared94 gsquared94 requested a review from briandealwis May 4, 2021 21:23
@gsquared94 gsquared94 merged commit 608ba98 into GoogleContainerTools:master May 5, 2021
@ngraf
Copy link

ngraf commented May 5, 2021

A colleague of mine, who is working on Windows machine, installed latest Skaffold binary and confirmed it is fixed. 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[windows] Multiconfig skaffold bug with helm.setFiles
4 participants