-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix setting helm --setFiles
for Windows
#5648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5648 +/- ##
==========================================
+ Coverage 70.70% 70.79% +0.08%
==========================================
Files 428 436 +8
Lines 16199 16334 +135
==========================================
+ Hits 11454 11563 +109
- Misses 3900 3920 +20
- Partials 845 851 +6
Continue to review full report at Codecov.
|
is there a progress in the pull request, under windows no work with multi configurations is possible without this fix would be cool if you could push this a little bit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have more questions
Can you take another look @briandealwis ? |
A colleague of mine, who is working on Windows machine, installed latest Skaffold binary and confirmed it is fixed. 💚 |
Fixes #5595
Can be tested against the repro provided here