fix file sync comment in examples/hot-reload/skaffold.yaml #5693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsquared94
reviewed
Apr 19, 2021
| @@ -32,7 +32,7 @@ profiles: | |||
| DEBUG: 1 | |||
| sync: | |||
| manual: | |||
| # Sync all the javascript files that are in the src folder | |||
| # Sync all the python files that are in the src folder | |||
There was a problem hiding this comment.
Can you also make this change here:
skaffold/integration/examples/hot-reload/skaffold.yaml
Lines 35 to 38 in d030bc1
…ot-reload/skaffold.yaml
Codecov Report
@@ Coverage Diff @@
## master #5693 +/- ##
==========================================
- Coverage 70.64% 70.43% -0.22%
==========================================
Files 411 413 +2
Lines 15860 15946 +86
==========================================
+ Hits 11205 11231 +26
- Misses 3827 3883 +56
- Partials 828 832 +4
Continue to review full report at Codecov.
|
wuxingzhong
pushed a commit
to wuxingzhong/skaffold
that referenced
this pull request
Apr 21, 2021
…tainerTools#5693) * Change 'javascript files' to 'python files' in python manual sync comment * Change 'javascript files' to 'python files' in integration/examples/hot-reload/skaffold.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The comment in the python manual sync section of the skaffold.yaml erroneously refers to 'javascript'; this changes it to 'python'.