Skip to content

Update hack/new_version.sh script and generate v2beta16 #5748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 29, 2021

Conversation

MarlonGamez
Copy link
Contributor

@MarlonGamez MarlonGamez commented Apr 28, 2021

Description
Generates schema version v2beta16.
This will unblock #5706
Also updates the code related to hack/new_version.sh to be aligned with refactor introduced by #5728.

@tejal29
Copy link
Contributor

tejal29 commented Apr 28, 2021

Thanks for fixing the hack script. Can you please link or mention the config changes for which we are doing the schema bump?

@tejal29
Copy link
Contributor

tejal29 commented Apr 28, 2021

Thanks! Approved!

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #5748 (b67d899) into master (d38ab4d) will decrease coverage by 0.20%.
The diff coverage is 27.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5748      +/-   ##
==========================================
- Coverage   70.87%   70.66%   -0.21%     
==========================================
  Files         421      423       +2     
  Lines       16087    16165      +78     
==========================================
+ Hits        11401    11423      +22     
- Misses       3850     3901      +51     
- Partials      836      841       +5     
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/v1/config.go 58.82% <ø> (ø)
pkg/skaffold/schema/v2beta14/upgrade.go 100.00% <ø> (ø)
pkg/skaffold/schema/versions.go 82.41% <ø> (ø)
pkg/skaffold/schema/v2beta15/config.go 20.58% <20.58%> (ø)
pkg/skaffold/schema/v2beta15/upgrade.go 100.00% <100.00%> (ø)
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
pkg/skaffold/errors/errors.go 95.45% <0.00%> (+0.14%) ⬆️
pkg/skaffold/docker/parse.go 87.14% <0.00%> (+0.95%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d38ab4d...b67d899. Read the comment docs.

@MarlonGamez MarlonGamez merged commit 789d058 into GoogleContainerTools:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants