Skip to content

Add pointer for .NET debugging for Rider #5924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 1, 2021

Conversation

briandealwis
Copy link
Member

Description
skaffold debug's setup for .NET Core does not work for JetBrains Rider. Add a pointer to Cloud Code for IntelliJ's workaround. The PR also puts the OmniSharp details into a separate call out.

@briandealwis briandealwis added the docs-modifications runs the docs preview service on the given PR label Jun 1, 2021
@briandealwis briandealwis requested a review from a team as a code owner June 1, 2021 19:16
@briandealwis briandealwis requested a review from tejal29 June 1, 2021 19:16
@google-cla google-cla bot added the cla: yes label Jun 1, 2021
@container-tools-bot
Copy link

Please visit http://35.235.96.90:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Jun 1, 2021
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

1 similar comment
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

{{< /alert >}}

{{< alert title="JetBrains Rider" >}}
This set up does not yet work with JetBrains' Rider,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not yet work [automatically | out of the box] with JetBrains Rider ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed on chat:

does not yet work automatically with Cloud Code for IntelliJ in JetBrains Rider

is even clearer

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #5924 (8ae3ffd) into master (0549530) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5924      +/-   ##
==========================================
- Coverage   70.90%   70.90%   -0.01%     
==========================================
  Files         448      449       +1     
  Lines       16968    16974       +6     
==========================================
+ Hits        12032    12035       +3     
- Misses       4038     4040       +2     
- Partials      898      899       +1     
Impacted Files Coverage Δ
pkg/skaffold/event/v2/event.go 73.91% <0.00%> (-2.61%) ⬇️
pkg/skaffold/docker/image.go 78.34% <0.00%> (-1.39%) ⬇️
pkg/skaffold/docker/parse.go 86.19% <0.00%> (-0.96%) ⬇️
pkg/skaffold/build/cache/retrieve.go 65.34% <0.00%> (-0.28%) ⬇️
pkg/skaffold/server/server.go 41.96% <0.00%> (ø)
pkg/skaffold/event/v2/build.go 100.00% <0.00%> (ø)
pkg/skaffold/runner/build_deploy.go 73.95% <0.00%> (+0.27%) ⬆️
pkg/skaffold/util/tar.go 56.00% <0.00%> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0549530...8ae3ffd. Read the comment docs.

@briandealwis briandealwis enabled auto-merge (squash) June 1, 2021 19:29
@etanshaul
Copy link
Contributor

had a tiny suggestion. but LGTM.

@briandealwis briandealwis merged commit f477f48 into GoogleContainerTools:master Jun 1, 2021
@briandealwis briandealwis deleted the rider branch June 1, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants