Skip to content

Document inputDigest tagger, and move sha256 tagger to end #5948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

briandealwis
Copy link
Member

Fixes: #5842

Description
Document the new inputDIgest tagger and de-emphasize the sha256 tagger by moving it to the end.

User facing changes (remove if N/A)

  • the new inputDigest tagger uses a digest of the source files to the image

@briandealwis briandealwis requested a review from a team as a code owner June 4, 2021 20:23
@briandealwis briandealwis requested a review from gsquared94 June 4, 2021 20:23
@google-cla google-cla bot added the cla: yes label Jun 4, 2021
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #5948 (4b53c8e) into master (fafdcd7) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5948      +/-   ##
==========================================
- Coverage   70.67%   70.64%   -0.03%     
==========================================
  Files         454      454              
  Lines       17395    17403       +8     
==========================================
+ Hits        12294    12295       +1     
- Misses       4195     4198       +3     
- Partials      906      910       +4     
Impacted Files Coverage Δ
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
...ffold/kubernetes/portforward/resource_forwarder.go 78.87% <0.00%> (-1.73%) ⬇️
pkg/skaffold/docker/image.go 78.34% <0.00%> (-1.39%) ⬇️
pkg/skaffold/event/v2/event.go 74.03% <0.00%> (+0.12%) ⬆️
pkg/skaffold/runner/v1/dev.go 73.11% <0.00%> (+0.12%) ⬆️
pkg/skaffold/docker/parse.go 87.14% <0.00%> (+0.95%) ⬆️
...skaffold/kubernetes/debugging/container_manager.go 50.98% <0.00%> (+0.98%) ⬆️
...affold/kubernetes/portforward/forwarder_manager.go 50.00% <0.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fafdcd7...4b53c8e. Read the comment docs.

@tejal29 tejal29 enabled auto-merge (squash) June 4, 2021 20:43
@tejal29 tejal29 merged commit 0b96ef3 into GoogleContainerTools:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document inputDigest tagger and move sha256 tagger to end
2 participants