Use StdEncoding for git hash directory name #6071
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6025
Description
base64.UrlEncoding
uses the "alternative alphabet" from RFC 4648, which supports the-
characters. When this character is the leading character of a computed hash, using this as an argument to anygit
command causes an error because it's misinterpreted as a command switch.base64.StdEncoding
does not support the-
character in its alphabet, so we should be able to use this encoder as a drop-in replacement with no issues.