Skip to content

Add information about workspace and dockerfile to artifact metadata #6111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MarlonGamez
Copy link
Contributor

Description
This PR adds information about an artifacts context, and in some cases dockerfile, to metadata events that get emitted through skaffold's event API.

@MarlonGamez MarlonGamez requested a review from a team as a code owner June 29, 2021 21:50
@MarlonGamez MarlonGamez requested a review from gsquared94 June 29, 2021 21:50
@google-cla google-cla bot added the cla: yes label Jun 29, 2021
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #6111 (a5f669d) into master (58a4652) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6111   +/-   ##
=======================================
  Coverage   70.16%   70.16%           
=======================================
  Files         475      475           
  Lines       18191    18194    +3     
=======================================
+ Hits        12763    12766    +3     
  Misses       4486     4486           
  Partials      942      942           
Impacted Files Coverage Δ
pkg/skaffold/event/v2/metadata.go 89.18% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a4652...a5f669d. Read the comment docs.

@MarlonGamez MarlonGamez merged commit 43d19d6 into GoogleContainerTools:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants