Fix couldn't start notify trigger in multi-config projects #6114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsquared94
approved these changes
Jun 30, 2021
|
Travis CI is stuck, merging based on successful Github Actions CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the problem that notify trigger does not start in multi-config projects.
Here is how to reproduce the problem.
The current code expects the workspace path is an relative path.
However, in multi-config projects, the workspace path seems to have already been converted to an absolute path.
User facing changes
The notify trigger will also work in multi-config projects.
This will reduce CPU usage in multi-config projects with a large number of files.