Skip to content

Check release workflow #6188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

briandealwis
Copy link
Member

Change draft-release workflow to use the actions-ecosystem/action-regex-match workflow for extracting regexs from the PR commit message, and to ignore the trailing PR number.

Although it adds the ability to include pre-release labels (e.g., 1.2.3-beta.1) to let us try cutting pre-release versions, our current post-release workflows (such as to publish docs to skaffold.dev) don't check that a tag is a full release.

Use actions-ecosystem/action-regex-match to avoid possible
injection attacks via commit messages.
@briandealwis briandealwis requested a review from gsquared94 July 12, 2021 19:45
@briandealwis briandealwis requested a review from a team as a code owner July 12, 2021 19:45
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #6188 (2043d04) into master (0b13fa0) will increase coverage by 1.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6188      +/-   ##
==========================================
+ Coverage   69.92%   71.10%   +1.18%     
==========================================
  Files         481      483       +2     
  Lines       18342    21549    +3207     
==========================================
+ Hits        12825    15323    +2498     
- Misses       4562     5247     +685     
- Partials      955      979      +24     
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/v2/config.go 5.40% <0.00%> (-94.60%) ⬇️
pkg/skaffold/schema/v3alpha1/config.go 2.70% <0.00%> (-47.30%) ⬇️
pkg/skaffold/render/generate/generate.go 52.38% <0.00%> (-24.98%) ⬇️
pkg/skaffold/initializer/build/builders.go 60.00% <0.00%> (-10.00%) ⬇️
pkg/skaffold/build/gcb/types.go 44.44% <0.00%> (-9.41%) ⬇️
cmd/skaffold/app/cmd/version.go 77.77% <0.00%> (-7.94%) ⬇️
pkg/skaffold/status/provider.go 75.00% <0.00%> (-6.82%) ⬇️
pkg/skaffold/build/cluster/types.go 93.33% <0.00%> (-6.67%) ⬇️
pkg/skaffold/sync/provider.go 65.00% <0.00%> (-6.43%) ⬇️
pkg/skaffold/server/v2/endpoints.go 34.69% <0.00%> (-6.34%) ⬇️
... and 468 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b13fa0...2043d04. Read the comment docs.

@tejal29
Copy link
Contributor

tejal29 commented Jul 13, 2021

@googlebot I signed it

@google-cla google-cla bot added the cla: yes label Jul 13, 2021
@briandealwis briandealwis merged commit 6391c38 into GoogleContainerTools:master Jul 13, 2021
@briandealwis briandealwis deleted the check-release-workflow branch July 13, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants